Should I submit the fix anyway ? At least it solves the problem in a few defined cases ?

Regards,

Wolfgang

P.S: Do you need a fix for the trunk, 1.2.1 or both ?

After writing some more test cases I figured out, that my fix does not work under all circumstances. The main problem seems to be that there are some assumption about the order of the parameter types (filter, named, positional) which are not correct if a subquery is used. My fix would solve the problem for criteria and queries without named parameters, but would still fail if one or more named parameters are used.

After some more analysis, I found out, that even a simple query won’t work, if you mix named and positional parameters:

IQuery query = session.CreateQuery( “from A as a where a.ValueA > :ValA and a.ValueA < ?" );

            query.SetParameter( "ValA", 5 );

            query.SetInt32( 0, 7 );

NHibernate: select … where (a0_.val_a>@p0 )and(a0_.val_a<@p1 ); @p0 = '7', @p1 = '5'

@p0 and @p1 contain the wrong values. Sure, it not really reasonable to mix positional and named parameters in a query, but on the other hand I can’t remember any constraint on that.

I tested all this on 1.2.1-GA, but I also had a quick look at the trunk and there seem to be no difference in handling the parameters.

Regards,

Wolfgang

Can you submit a patch + test case for this?